Content Types: Fix MovePropertyType orphaning the property when moving it to no group (closes #23481) - #23493

oldPropertyGroup?.PropertyTypes?.RemoveItem(propertyTypeAlias);
newPropertyGroup?.PropertyTypes?.Add(propertyType);   // no-op when moving to no group

oldPropertyGroup?.PropertyTypes?.RemoveItem(propertyTypeAlias);

if (newPropertyGroup is null)
{
    if (PropertyTypeCollection.Contains(propertyTypeAlias) == false)
    {
        PropertyTypeCollection.Add(propertyType);
    }
}
else
{
    PropertyTypeCollection.RemoveItem(propertyTypeAlias);
    newPropertyGroup.PropertyTypes?.Add(propertyType);
}

using System.Text;
using Microsoft.AspNetCore.Mvc;
using Umbraco.Cms.Core;
using Umbraco.Cms.Core.Models;
using Umbraco.Cms.Core.Services;
using Umbraco.Cms.Core.Services.OperationStatus;

namespace Umbraco.Cms.Web.UI.Controllers;

/// <summary>
/// Debug controller to reproduce #23481: IContentTypeBase.MovePropertyType(alias, null) orphans the
/// property instead of moving it to "generic properties".
///
/// Setup:
///   1. Create a document type (e.g. "debugDocType") with a group "Content" holding a property "title"
///   2. Create a content item of that type, set "title" to something recognisable, and save
///
/// Move to no group:
///   /debug/move-property-type?contentTypeAlias=debugDocType&amp;propertyAlias=title
///
///   Broken (without fix): AFTER MOVE shows "title" in neither collection; AFTER RELOAD it is gone
///                         entirely - the property type and its content values were deleted on save.
///   Expected (with fix):  AFTER MOVE and AFTER RELOAD both show "title" under (no group), the group
///                         is empty, and the content item keeps its value.
///
/// Move back into a group:
///   /debug/move-property-type?contentTypeAlias=debugDocType&amp;propertyAlias=title&amp;targetGroupAlias=content
///
///   Broken (without fix): AFTER MOVE shows "title" in *both* the group and (no group).
///   Expected (with fix):  only in the group, both in memory and after reload.
/// </summary>
[ApiController]
[Route("debug/move-property-type")]
public class DebugMovePropertyTypeController : ControllerBase
{
    private readonly IContentTypeService _contentTypeService;

    public DebugMovePropertyTypeController(IContentTypeService contentTypeService)
        => _contentTypeService = contentTypeService;

    [HttpGet]
    public async Task<IActionResult> Index(
        [FromQuery] string contentTypeAlias,
        [FromQuery] string propertyAlias,
        [FromQuery] string? targetGroupAlias = null)
    {
        var sb = new StringBuilder();
        sb.AppendLine("=== MovePropertyType Debug (#23481) ===");
        sb.AppendLine($"Content type:  {contentTypeAlias}");
        sb.AppendLine($"Property:      {propertyAlias}");
        sb.AppendLine($"Target group:  {targetGroupAlias ?? "(no group / generic properties)"}");
        sb.AppendLine();

        IContentType? contentType = _contentTypeService.Get(contentTypeAlias);
        if (contentType is null)
        {
            sb.AppendLine($"Content type '{contentTypeAlias}' not found.");
            return Content(sb.ToString(), "text/plain");
        }

        AppendSnapshot(sb, "BEFORE", contentType);

        var moved = contentType.MovePropertyType(propertyAlias, targetGroupAlias);
        sb.AppendLine($"MovePropertyType returned: {moved}");
        sb.AppendLine();

        AppendSnapshot(sb, "AFTER MOVE, IN MEMORY", contentType);

        Attempt<ContentTypeOperationStatus> saveResult =
            await _contentTypeService.UpdateAsync(contentType, Constants.Security.SuperUserKey);
        sb.AppendLine($"Save status: {saveResult.Result}");
        sb.AppendLine();

        AppendSnapshot(sb, "AFTER SAVE + RELOAD", _contentTypeService.Get(contentTypeAlias));

        return Content(sb.ToString(), "text/plain");
    }

    private static void AppendSnapshot(StringBuilder sb, string label, IContentType? contentType)
    {
        sb.AppendLine($"--- {label} ---");
        if (contentType is null)
        {
            sb.AppendLine("  Content type not found");
            sb.AppendLine();
            return;
        }

        sb.AppendLine($"  PropertyTypes count: {contentType.PropertyTypes.Count()}");

        foreach (PropertyGroup group in contentType.PropertyGroups)
        {
            var aliases = group.PropertyTypes?.Select(x => x.Alias).ToArray() ?? [];
            sb.AppendLine($"  group '{group.Alias}' (id {group.Id}): {Describe(aliases)}");
        }

        var noGroupAliases = contentType.NoGroupPropertyTypes.Select(x => x.Alias).ToArray();
        sb.AppendLine($"  (no group): {Describe(noGroupAliases)}");
        sb.AppendLine();
    }

    private static string Describe(string[] aliases) => aliases.Length == 0
        ? "(empty)"
        : string.Join(", ", aliases);
}